Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Added the Ability to set an Icon for Toggles #30

Merged
merged 6 commits into from
Jul 11, 2022

Conversation

Gamersven
Copy link
Contributor

Hi Requi,

i thought this "should" be in your Button API because you already had the Code for it in place.

Git is some Magic Stuff and i hope this is Acceptable.

Viele Grüße ^^

@RequiDev
Copy link
Owner

RequiDev commented Jul 8, 2022

While you're at it, could you extend it to also add the ability to change the "off" icon?

@Gamersven
Copy link
Contributor Author

Updated with iconOn and iconOff Options.
grafik

@RequiDev
Copy link
Owner

RequiDev commented Jul 9, 2022

Due to how C# works, could you create a new overload instead of adding parameters? If this goes live all mods using AddToggle would complain because the method signature changed and it can't find the method it compiled against.

@Gamersven
Copy link
Contributor Author

Added the requested overloads.

@RequiDev
Copy link
Owner

The same goes for constructors.

@RequiDev RequiDev merged commit 2c4fb93 into RequiDev:master Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants